Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

297 Fix nacl.secret import #298

Merged
merged 1 commit into from
Sep 9, 2024
Merged

297 Fix nacl.secret import #298

merged 1 commit into from
Sep 9, 2024

Conversation

dantownsend
Copy link
Member

Resolves #297

@dantownsend dantownsend added the bug Something isn't working label Sep 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.40%. Comparing base (9cc0966) to head (ca50803).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
piccolo_api/encryption/providers.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   92.69%   90.40%   -2.30%     
==========================================
  Files          34       42       +8     
  Lines        2053     2459     +406     
==========================================
+ Hits         1903     2223     +320     
- Misses        150      236      +86

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend dantownsend merged commit d44d03b into master Sep 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Bugs
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix nacl.secret import
2 participants
@dantownsend @codecov-commenter